| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Magnus Hagander <magnus(at)hagander(dot)net> |
| Cc: | Michael Banck <michael(dot)banck(at)credativ(dot)de>, Stephen Frost <sfrost(at)snowman(dot)net>, David Steele <david(at)pgmasters(dot)net>, PostgreSQL Developers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Robert Haas <robertmhaas(at)gmail(dot)com> |
| Subject: | Re: [PATCH] Verify Checksums during Basebackups |
| Date: | 2018-04-03 14:32:13 |
| Message-ID: | 3980.1522765933@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
I wrote:
> Magnus Hagander <magnus(at)hagander(dot)net> writes:
>> Unless.. %ld is the wrong thing to print:
>> static int64 total_checksum_failures;
>> We should perhaps be using something other than %ld to print that?
> INT64_FORMAT.
BTW, don't just stick INT64_FORMAT into the message-to-be-translated,
or you'll break things for translation. Good practice is to sprintf
into a local char array with INT64_FORMAT, then include the number
into the displayed message with %s. You can find examples easily
by grepping for INT64_FORMAT.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tomas Vondra | 2018-04-03 14:34:52 | Re: [HACKERS] logical decoding of two-phase transactions |
| Previous Message | Tom Lane | 2018-04-03 14:29:40 | Re: [PATCH] Verify Checksums during Basebackups |