Re: Small patch for memory leak in src/backend/catalog/pg_proc.c

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Denis Perchine <dyp(at)perchine(dot)com>
Cc: pgsql-patches(at)postgresql(dot)org
Subject: Re: Small patch for memory leak in src/backend/catalog/pg_proc.c
Date: 2000-06-13 15:06:01
Message-ID: 3971.960908761@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

Denis Perchine <dyp(at)perchine(dot)com> writes:
***************
*** 327,331 ****
--- 327,332 ----
CatalogCloseIndices(Num_pg_proc_indices, idescs);
}
heap_close(rel, RowExclusiveLock);
+ heap_freetuple(tup);
return tup->t_data->t_oid;
}

Uh, you didn't notice that the tuple you just freed is still in use
on the next line?

Memory leaks like this are not worth worrying about because the memory
will be reclaimed at end of transaction --- maybe even sooner after
I improve the memory-context handling.

regards, tom lane

In response to

Responses

Browse pgsql-patches by date

  From Date Subject
Next Message Tom Lane 2000-06-13 15:16:57 Re: Big 7.1 open items
Previous Message Tom Lane 2000-06-13 15:03:39 Re: Big 7.1 open items