| From: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
|---|---|
| To: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: pg_dump should use current_database() instead of PQdb() |
| Date: | 2018-05-04 13:37:03 |
| Message-ID: | 39662334-ec23-d762-4711-ae5e253b119a@2ndquadrant.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 4/10/18 12:40, Peter Eisentraut wrote:
> A report from a pgbouncer user revealed that running pg_dump -C/--create
> does not work through a connection proxy if the virtual database name on
> the proxy does not match the real database name on the database server.
> That's because pg_dump looks up the database to be dumped using the
> information from PQdb(). It should be using current_database() instead.
> (The code was quite likely written before current_database() was
> available (PG 7.3)).
>
> See attached patch.
committed
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2018-05-04 13:37:55 | Re: Is there a memory leak in commit 8561e48? |
| Previous Message | Michael Paquier | 2018-05-04 13:35:33 | Re: Proper way to reload config files in backend SIGHUP handler |