From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | Andres Freund <andres(at)anarazel(dot)de> |
Cc: | pgsql-hackers(at)lists(dot)postgresql(dot)org |
Subject: | Re: More weird compiler warnings |
Date: | 2023-03-16 18:31:37 |
Message-ID: | 3959491.1678991497@sss.pgh.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Andres Freund <andres(at)anarazel(dot)de> writes:
> On 2022-03-26 13:55:49 -0700, Andres Freund wrote:
>> On 2022-03-26 16:23:26 -0400, Tom Lane wrote:
>>> but I'm wondering if we could silence the warning by changing the loop condition to
>>> while (--nb >= 0)
>>> which seems like it might be marginally more readable anyway.
>> Yes, that looks like it silences it. I modified the small reproducer I had in
>> that bug (https://godbolt.org/z/ejK9h6von) and the warning vanishes.
> The recent discussion about warnings reminded me of this. Given the gcc bug
> hasn't been fixed, I think we should make that change. I'd vote for
> backpatching it as well - what do you think?
+1, can't hurt anything AFAICS.
regards, tom lane
From | Date | Subject | |
---|---|---|---|
Next Message | Jim Jones | 2023-03-16 19:07:06 | Re: [PATCH] Add pretty-printed XML output option |
Previous Message | Tom Lane | 2023-03-16 18:20:22 | Re: Date-Time dangling unit fix |