Re: Code cleanup patch submission for extended_stats.c

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Mark Dilger <hornschnorter(at)gmail(dot)com>
Cc: PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
Subject: Re: Code cleanup patch submission for extended_stats.c
Date: 2017-11-25 22:05:39
Message-ID: 3951.1511647539@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Mark Dilger <hornschnorter(at)gmail(dot)com> writes:
> It looks to me like Alvaro introduced this in the original version of the file which
> was created in commit 7b504eb282ca2f5104b5c00b4f05a3ef6bb1385b. Grep'ing
> through the code base, it seems the following would be more consistent with
> how these initializations are handled elsewhere:

> memset(nulls, 1, sizeof(nulls));
> memset(replaces, 0, sizeof(replaces));
> memset(values, 0, sizeof(values));

+1. I'd be inclined to use "false" and "true" for the init values of
the boolean arrays, too.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tomas Vondra 2017-11-25 23:18:11 Re: [HACKERS] PATCH: multivariate histograms and MCV lists
Previous Message Fabien COELHO 2017-11-25 21:33:53 pgbench - add \if support