| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Richard Guo <guofenglinux(at)gmail(dot)com> |
| Cc: | Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com>, John Naylor <johncnaylorls(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Fix missing FORMAT when deparsing JSON_ARRAY(query) |
| Date: | 2026-07-27 13:43:51 |
| Message-ID: | 3946487.1785159831@sss.pgh.pa.us |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Richard Guo <guofenglinux(at)gmail(dot)com> writes:
> On Sat, Jul 25, 2026 at 1:34 AM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>> Anyway, I've actually reviewed the attached v2 and think it's solid.
> v2 LGTM.
Pushed. BTW, while I was doing that I noticed that your predecessor
commits (f4c850d11, aa50f4f02) assigned the same catversion 202607271
in both branches. That's not good practice: it's likely that there
are already other discrepancies between v19 and v20 catalogs, and
in any case the whole point of the catversion mechanism is to prevent
confusion. You can use the same date in both branches, but use
different last digits. In my change, I used 202607272 for v19 and
202607273 for master.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Pavel Stehule | 2026-07-27 14:09:45 | Re: POC: PLpgSQL FOREACH IN JSON ARRAY |
| Previous Message | David Rowley | 2026-07-27 13:41:13 | Re: [PATCH] Speed up repeat() for larger counts |