| From: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Fabrízio de Royes Mello <fabriziomello(at)gmail(dot)com> |
| Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Add CREATE DATABASE LOCALE option |
| Date: | 2019-06-23 18:13:28 |
| Message-ID: | 392d8e8b-0f52-16a8-50ab-ae31a97cc219@2ndquadrant.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2019-06-06 21:52, Alvaro Herrera wrote:
> On 2019-Jun-06, Fabrízio de Royes Mello wrote:
>
>>>> Cool... would be nice also add some test cases.
>>>
>>> Right. Any suggestions where to put them?
>>
>> Hmm... good question... I thought we already have some regression tests for
>> {CREATE|DROP} DATABASE but actually we don't... should we add a new one?
>
> I think pg_dump/t/002_pg_dump.pl might be a good place. Not the easiest
> program in the world to work with, admittedly.
Updated patch with test and expanded documentation.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| Attachment | Content-Type | Size |
|---|---|---|
| v2-0001-Add-CREATE-DATABASE-LOCALE-option.patch | text/plain | 6.6 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | James Coleman | 2019-06-23 19:22:04 | Misleading comment in tuplesort_set_bound |
| Previous Message | Dean Rasheed | 2019-06-23 17:56:53 | Re: Multivariate MCV stats can leak data to unprivileged users |