| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Simon Riggs <simon(at)2ndquadrant(dot)com> |
| Cc: | Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>, Oliver Jowett <oliver(at)opencloud(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: statement logging / extended query protocol issues |
| Date: | 2005-09-05 19:38:27 |
| Message-ID: | 3922.1125949107@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers pgsql-patches |
Simon Riggs <simon(at)2ndquadrant(dot)com> writes:
> + /*
> + * If we re-issue an Execute protocol request against an existing
> + * portal, then we are only fetching more rows rather than
> + * completely re-executing the query from the start
> + */
> + if (!portal->atEnd)
> + subsequent_fetch = true;
That strikes me as a completely bogus test for a "re-issued" execute.
Did you mean !atStart?
Also, why is it a good idea to report the number of rows fetched in
some cases (and not others)?
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2005-09-05 19:45:56 | Re: PostgreSQL configurable SSL key checking |
| Previous Message | Alvaro Herrera | 2005-09-05 19:36:41 | Re: PostgreSQL configurable SSL key checking |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Oliver Jowett | 2005-09-05 22:54:05 | Re: statement logging / extended query protocol issues |
| Previous Message | Simon Riggs | 2005-09-05 19:08:46 | Re: statement logging / extended query protocol issues |