Re: Inconsistent nullingrels due to oversight in deconstruct_distribute_oj_quals

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Richard Guo <guofenglinux(at)gmail(dot)com>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Inconsistent nullingrels due to oversight in deconstruct_distribute_oj_quals
Date: 2023-02-09 16:28:44
Message-ID: 3911446.1675960124@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

I wrote:
> Richard Guo <guofenglinux(at)gmail(dot)com> writes:
>> It seems to me there is oversight here. Actually in next level up this
>> othersj would null all the relids in its syn_righthand, not only the
>> relids in its min_righthand.

> Good point. I think this code originated before it was clear to me
> that nullingrels would need to follow the syntactic structure.

Although ... the entire point here is that we're trying to build quals
that don't match the original syntactic structure. I'm worried that
distribute_qual_to_rels will do the wrong thing (put the qual at the
wrong level) if we add more nullingrel bits than we meant to. This
might be less trivial than it appears.

regards, tom lane

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Himanshu Upadhyaya 2023-02-09 17:09:09 Re: HOT chain validation in verify_heapam()
Previous Message Robert Haas 2023-02-09 16:12:21 Re: Weird failure with latches in curculio on v15