Re: incorrect error message, while dropping PROCEDURE

From: Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>
To: Rushabh Lathia <rushabh(dot)lathia(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: incorrect error message, while dropping PROCEDURE
Date: 2017-12-14 15:18:34
Message-ID: 38addf0d-8c5c-fbb0-2aad-fafd57f21e0a@2ndquadrant.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 12/13/17 23:31, Rushabh Lathia wrote:
> Currently if some one try to drop the PROCEDURE and
> it don't have privilege or it's not an owner, than error message
> still indicate object as FUNCTION.

Yes, that is actually something that is fixed by the patches proposed in
the thread "replace GrantObjectType with ObjectType".

> PFA patch, where introduced new AclObjectKind (ACL_KIND_PROCEDURE),
> msg for the new AclObjectKind, and passed it through at
> appropriate places.

Yeah, that's a way to do it, but having both ACL_KIND_PROC and
ACL_KIND_PROCEDURE is clearly confusing. The above-mentioned patch
cleans that up more thoroughly, I think.

--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2017-12-14 15:21:44 Re: [HACKERS] Custom compression methods
Previous Message Robert Haas 2017-12-14 15:12:45 Re: access/parallel.h lacks PGDLLIMPORT