Re: [HACKERS] Patch attached...

From: Hannu Krosing <hannu(at)tm(dot)ee>
To: Chris <chris(at)bitmead(dot)com>
Cc: Postgres Hackers List <hackers(at)postgreSQL(dot)org>
Subject: Re: [HACKERS] Patch attached...
Date: 2000-02-05 19:30:15
Message-ID: 389C7A47.296E1A87@tm.ee
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Chris wrote:
>
> Hannu Krosing wrote:
> >
> > Hi
> >
> > I looked at the patch and for me the name of the variable
> > to set to get the old behaviour (SET EXAMINE_SUBCLASS TO 'on';)
> > seems confusing.
> >
> > At first I thought it was a typo to set it to 'ON' for old behaviour,
> > my internal logic would set it to 'OFF' to not select subclass by default.
>
> Umm, but that IS how it works...

I don't contest that ;)

> > I think something like DONT_SELECT_INHERITED or OLD_INHERITED_SELECT_SYNTAX
> > would be much clearer in meaning.
>
> I'm happy to hear alternative names, but I don't really want "SELECT" in
> the name, because this might apply to UPDATE eventually too.

Oops, I didnt think of that.

Of course it should actually apply to all four (SELECT, UPDATE, SELETE,
INSERT)
as wellas DDL statements (ALTER TABLE ADD/DROP xxx, CREATE
CONSTRAINT/INDEX/RULE/TRIGGER)

------------------
Hannu

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Hannu Krosing 2000-02-05 19:55:05 Re: [HACKERS] Status of inheritance-changing patch
Previous Message Oleg Bartunov 2000-02-05 18:15:35 Linux MANDRAKE startup startup script is broken ?