Re: Re[2]: PG 14.5 -- Impossible to restore dump due to interaction/order of views, functions, and generated columns

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: "Nunya Business" <nb3425586(at)gmail(dot)com>
Cc: pgsql-general(at)postgresql(dot)org, pgsql-bugs(at)postgresql(dot)org
Subject: Re: Re[2]: PG 14.5 -- Impossible to restore dump due to interaction/order of views, functions, and generated columns
Date: 2022-12-06 20:47:26
Message-ID: 3892582.1670359646@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs pgsql-general

"Nunya Business" <nb3425586(at)gmail(dot)com> writes:
> Thanks Tom. There are indeed circular references in the schema and the
> whole thing sort of doesn't pass the smell test, but this is my first
> look at it. The generated column on the table calls a function which
> selects from a view that references the table. The production schema
> where I ran into this is pretty large and complex, so the contrived
> example that follows may not be the minimum working example but it's
> pretty small and has the same behavior regarding the SQL generated by
> pg_dumpall.

Hm. The actual problem here is that fnA() is making unwarranted
assumptions about the search_path it's run under, so it fails when the
pg_dump script invokes it with a restrictive search_path. If you change
the function text so that the references to viewA are schema-qualified,
then it restores without errors.

"Doesn't pass the smell test" is putting it mildly, btw. Labeling
that function IMMUTABLE is a huge lie, and what it means is that
your GENERATED column doesn't have the amount of stability that
it's supposed to per spec. I'm not sure exactly what sorts of
misbehaviors might ensue from that, but I'm pretty certain that the
data in the GENERATED column after dump/restore won't match what
you had there beforehand.

regards, tom lane

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message Jeff Davis 2022-12-06 23:57:19 Re: CREATE COLLATION without LOCALE throws error in v15
Previous Message Nunya Business 2022-12-06 18:19:36 Re[2]: PG 14.5 -- Impossible to restore dump due to interaction/order of views, functions, and generated columns

Browse pgsql-general by date

  From Date Subject
Next Message qihua wu 2022-12-07 02:20:09 snapshot question
Previous Message vignesh C 2022-12-06 18:52:29 Re: Support logical replication of DDLs