Re: pgsql: Allow concurrent-safe open() and fopen() in frontend code for Wi

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Andrew Dunstan <andrew(dot)dunstan(at)2ndquadrant(dot)com>
Cc: Michael Paquier <michael(at)paquier(dot)xyz>, pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: Re: pgsql: Allow concurrent-safe open() and fopen() in frontend code for Wi
Date: 2018-09-17 16:13:56
Message-ID: 3883.1537200836@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

Andrew Dunstan <andrew(dot)dunstan(at)2ndquadrant(dot)com> writes:
> On 09/17/2018 10:48 AM, Tom Lane wrote:
>> We've got a bit of a timing problem because we want to wrap 11beta4/rc1
>> (still TBD) in a few hours. I'll take a look and see if I can push a
>> quick fix before that.

> When you do I'll start a bowerbird run to check it.

Pushed, please test.

I think there's a general issue here of exactly how we want pgwin32_fopen
to behave, but the immediate problem is best fixed by making pgbench deal
with Windows newlines more thoroughly.

regards, tom lane

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2018-09-17 16:43:13 pgsql: Remove dead code from pop_next_work_item().
Previous Message Tom Lane 2018-09-17 16:11:52 pgsql: Fix pgbench lexer's "continuation" rule to cope with Windows new

Browse pgsql-hackers by date

  From Date Subject
Next Message Steve Atkins 2018-09-17 16:17:13 Re: Code of Conduct plan
Previous Message Tomas Vondra 2018-09-17 16:13:44 Re: Online verification of checksums