From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | Peter Eisentraut <peter_e(at)gmx(dot)net> |
Cc: | David Fetter <david(at)fetter(dot)org>, pgsql-hackers(at)postgresql(dot)org |
Subject: | Re: pg_stat_user_functions' notion of user |
Date: | 2010-08-08 15:59:52 |
Message-ID: | 3861.1281283192@sss.pgh.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Peter Eisentraut <peter_e(at)gmx(dot)net> writes:
> On tor, 2010-08-05 at 07:13 -0700, David Fetter wrote:
>> On Thu, Aug 05, 2010 at 04:58:32PM +0300, Peter Eisentraut wrote:
>>> pg_stat_user_functions has an inconsistent notion of what "user" is.
>>> Whereas the other pg_stat_user_* views filter out non-user objects
>>> by schema, pg_stat_user_functions checks for language "internal",
>>> which does not successfully exclude builtin functions of language
>>> SQL. Is there a reason for this inconsistency?
> Would anyone object to changing it to make it more consistent with other
> others? And since we're jollily making catalog changes in 9.0 still,
> could this also be backpatched?
The reason for the inconsistency is that the underlying behavior is
different: fmgr automatically doesn't collect stats for internal
functions. And yes I will object to trying to change that right now.
It's not just a "catalog change".
regards, tom lane
From | Date | Subject | |
---|---|---|---|
Next Message | David E. Wheeler | 2010-08-08 16:01:41 | Re: Initial review of xslt with no limits patch |
Previous Message | Tom Lane | 2010-08-08 15:41:15 | Re: scheduling |