Re: pg_dump --with-* options

From: Jeff Davis <pgsql(at)j-davis(dot)com>
To: Nathan Bossart <nathandbossart(at)gmail(dot)com>
Cc: Robert Haas <robertmhaas(at)gmail(dot)com>, Peter Eisentraut <peter(at)eisentraut(dot)org>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: pg_dump --with-* options
Date: 2025-08-02 15:30:07
Message-ID: 3860919f09b1edc31f5c19adb3260836afd3283c.camel@j-davis.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, 2025-08-01 at 17:46 -0500, Nathan Bossart wrote:
> On Fri, Aug 01, 2025 at 12:42:16PM -0700, Jeff Davis wrote:
> > -      <term><option>--with-statistics</option></term>
> > +      <term><option>--statistics</option></term>
>
> > -      <term><option>--with-statistics</option></term>
> > +      <term><option>--statistics</option></term>
>
> > -      <term><option>--with-statistics</option></term>
> > +      <term><option>--statistics</option></term>
>
> nitpick: --statistics should be moved to maintain alphabetical
> ordering.
>

Thank you. I committed this and closed the Open Item.

I did not address the following issues:

* Did not change default to on: there was no consensus on this point,
and the default-off opinions were stronger. We may be able to revisit
for PG19.
* Did not add --include syntax: no patch and no consensus on the
details.
* Did not remove redundant --no-statistics option for pg_dump and
redundant --statistics option for pg_restore: kept for consistency
between pg_dump and pg_restore, and to allow us to potentially change
to default-on in the future.

If someone feels one of these needs to be addressed in PG18, let me
know.

Regards,
Jeff Davis

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Jeff Davis 2025-08-02 15:34:32 Re: pg_dump --with-* options
Previous Message Fujii Masao 2025-08-02 13:58:36 Re: pg_dump --with-* options