| From: | Damien Clochard <damien(at)dalibo(dot)info> |
|---|---|
| To: | Vik Fearing <vik(at)postgresfriends(dot)org> |
| Cc: | Greg Sabino Mullane <htamfids(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Dean Rasheed <dean(dot)a(dot)rasheed(at)gmail(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: [PATCH] Generate random dates/times in a specified range |
| Date: | 2025-08-25 11:42:35 |
| Message-ID: | 385bf869903f91aea778c16652cf0874@dalibo.info |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Le 24.07.2025 20:24, Vik Fearing a écrit :
>> [...]
>
> Just a small cosmetic gripe, the regression test comments are usually
> "-- ok" and "--fail", and not "-- Should error".
>
Thanks Vik!
Here's a third version with the following changes:
* Rebase from master
* Replace 'Should error' by 'fail' in the test file
* move documentation from func.sgml to func/func-datetime.sgml
Note that former random function variants are documented in
func/func-math.sgml but it felt more logical to document the new
variants in func-datetime.sgml. As a result the random variants would be
documented in 2 separate sections of chapter 9.
--
Damien Clochard
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Kapila | 2025-08-25 11:51:27 | Re: [BUG?] check_exclusion_or_unique_constraint false negative |
| Previous Message | Amit Kapila | 2025-08-25 11:35:48 | Re: Conflict detection for update_deleted in logical replication |