Re: Small code cleanup

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Mark Dilger <mark(dot)dilger(at)enterprisedb(dot)com>
Cc: PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Small code cleanup
Date: 2020-06-01 15:53:00
Message-ID: 384749.1591026780@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Mark Dilger <mark(dot)dilger(at)enterprisedb(dot)com> writes:
> One line change to remove a duplicate check.

The comment just above this mentions a connection to the "Finish printing
the footer information about a table" stanza below. I think some work is
needed to clarify what's going on there --- it doesn't seem actually
buggy, but there are multiple lies embedded in these comments. I'm also
questioning somebody's decision to wedge partitioning into this logic
without refactoring any existing if's, as they seem to have done. At the
very least we're issuing useless queries here, for instance looking for
inheritance parents of matviews.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Mark Dilger 2020-06-01 16:23:07 Re: Small code cleanup
Previous Message Mark Dilger 2020-06-01 15:37:12 Small code cleanup