Re: Odd(?) RI-trigger behavior

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Joe Conway <mail(at)joeconway(dot)com>
Cc: Alvaro Herrera <alvherre(at)atentus(dot)com>, Stephan Szabo <sszabo(at)megazone23(dot)bigpanda(dot)com>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: Odd(?) RI-trigger behavior
Date: 2002-04-19 20:36:33
Message-ID: 3842.1019248593@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

Joe Conway <mail(at)joeconway(dot)com> writes:
> There is already a RenameStmt node which is currently only used to
> rename tables or table column names. Is there any objection to modifying
> it to handle trigger names (and possibly other things in the future) also?

You'd need to add a field so you could distinguish the type of rename,
but on the whole that seems a reasonable thing to do; probably better
than adding a brand new node type. We're already sharing node types
for DROPs, for example, so I see no reason not to do it for RENAMEs.
(Cf 'DropPropertyStmt' in current sources)

Renaming rules seems like something that should be on the list too,
so you're right that there will be more stuff later.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Joe Conway 2002-04-20 00:47:02 RENAME TRIGGER patch (was [HACKERS] Odd(?) RI-trigger behavior)
Previous Message Joe Conway 2002-04-19 20:29:33 Re: Odd(?) RI-trigger behavior

Browse pgsql-patches by date

  From Date Subject
Next Message Joe Conway 2002-04-20 00:47:02 RENAME TRIGGER patch (was [HACKERS] Odd(?) RI-trigger behavior)
Previous Message Joe Conway 2002-04-19 20:29:33 Re: Odd(?) RI-trigger behavior