Re: pgsql/src (Makefile.global.in)

I'm going to get rid of all #ifdef XLOG in code soon...

Vadim

------Original Message------
From: Peter Eisentraut <peter_e(at)gmx(dot)net>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Sent: November 20, 2000 4:52:38 PM GMT
Subject: Re: [COMMITTERS] pgsql/src (Makefile.global.in)

Tom Lane writes:

> vadim(at)postgresql(dot)org writes:
>
> *** 145,150 ****
> --- 145,152 ----
> ifeq ($(GCC), yes)
> CFLAGS += -Wall -Wmissing-prototypes -Wmissing-declarations
> endif
> +
> + CFLAGS += -DXLOG

(Should be CPPFLAGS anyway.)

>
> CXX = @CXX@
> GXX = @GXX@
>
> Ick. Couldn't we do this by #define XLOG in config.h.in, instead?
> CFLAGS are horribly vulnerable to people overriding them with
> make options.
>
> I do recall that when I last tried to build with WAL, my attempt
> to add #define XLOG to config.h failed --- but that indicates poor
> coding practices elsewhere. It *should* work to add or remove a
> feature symbol in config.h.

Surely checking #ifdef XLOG before including postgres.h won't help. Fix
coming in right now.

--
Peter Eisentraut peter_e(at)gmx(dot)net http://yi.org/peter-e/

-----------------------------------------------
FREE! The World's Best Email Address @email.com
Reserve your name now at http://www.email.com