| From: | "Andrew Dunstan" <andrew(at)dunslane(dot)net> |
|---|---|
| To: | "Bill Moran" <wmoran(at)collaborativefusion(dot)com> |
| Cc: | "Andrew Dunstan" <andrew(at)dunslane(dot)net>, pgsql-patches(at)postgresql(dot)org |
| Subject: | Re: [HACKERS] Patch to log usage of temporary files |
| Date: | 2007-01-04 01:05:27 |
| Message-ID: | 3813.24.211.165.134.1167872727.squirrel@www.dunslane.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers pgsql-patches |
Bill Moran wrote:
> Andrew Dunstan <andrew(at)dunslane(dot)net> wrote:
>>
>> Bill Moran wrote:
>> > + if (trace_temp_files != -1)
>> >
>>
>> Might be more robust to say
>>
>> if (trace_temp_files >= 0)
>
> Because it would allow for the easy addition of more negative numbers
> with magic value?
>
because ISTM any negative number here should mean no action is to be
taken. Otherwise how else is it different from 0?
cheers
andrew
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Jaime Casanova | 2007-01-04 01:42:20 | Re: TODO: Add a GUC to control whether BEGIN inside |
| Previous Message | Bill Moran | 2007-01-04 00:56:10 | Re: [HACKERS] Patch to log usage of temporary files |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Euler Taveira de Oliveira | 2007-01-04 01:46:57 | Re: xlog directory at initdb time |
| Previous Message | Bill Moran | 2007-01-04 00:56:10 | Re: [HACKERS] Patch to log usage of temporary files |