| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
| Cc: | Michael Paquier <michael(at)paquier(dot)xyz>, pgsql-hackers(at)lists(dot)postgresql(dot)org, pgbf(at)twiska(dot)com |
| Subject: | Re: Extracting cross-version-upgrade knowledge from buildfarm client |
| Date: | 2023-01-18 21:14:21 |
| Message-ID: | 3808228.1674076461@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Andrew Dunstan <andrew(at)dunslane(dot)net> writes:
> On 2023-01-18 We 14:32, Tom Lane wrote:
>> I suppose that the reason for not running under $from_source is to
>> avoid corrupting the saved installations with unofficial versions.
>> However, couldn't we skip the "save" step and still run the upgrade
>> tests against whatever we have saved? (Maybe skip the same-version
>> test, as it's not quite reflecting any real case then.)
> Something like this should do it:
> my $source_tree = $from_source || "$self->{buildroot}/$this_branch/pgsql";
Ah, I didn't understand that $from_source is a path not just a bool.
What do you think about the above questions? Is this $from_source
exclusion for the reason I guessed, or some other one?
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bruce Momjian | 2023-01-18 21:23:41 | Re: document the need to analyze partitioned tables |
| Previous Message | Nathan Bossart | 2023-01-18 21:14:14 | Re: almost-super-user problems that we haven't fixed yet |