| From: | Brendan Jurd <direvus(at)gmail(dot)com> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)commandprompt(dot)com> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Euler Taveira de Oliveira <euler(at)timbira(dot)com>, Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: WIP: to_char, support for EEEE format |
| Date: | 2009-08-10 04:05:57 |
| Message-ID: | 37ed240d0908092105u25ac65few9e0efcc794ba36ea@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
2009/8/9 Alvaro Herrera <alvherre(at)commandprompt(dot)com>:
> Brendan Jurd escribió:
>
>> Here's version 6 of the EEEE patch, now with an all-new implementation
>> of (normalised) scientific notation in numeric.c, via the functions
>> numeric_out_sci() and get_str_from_var_sci(). So EEEE should now be
>> able to represent the full gamut of the numeric type.
>
> I noticed an ugly pattern in NUMDesc_prepare calling a cleanup function
> before every ereport(ERROR). I think it's cleaner to replace that with
> a PG_TRY block; see attached.
Looks nice -- although doesn't have anything to do with the EEEE patch
so perhaps deserves its own thread?
>
> I didn't go over the patch in much more detail. (But the
> numeric_out_sci business got me thinking.)
Got you thinking about what? I'd welcome any comments you have.
Cheers,
BJ
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Jaime Casanova | 2009-08-10 05:39:17 | Re: pg_stat_activity.application_name |
| Previous Message | Greg Stark | 2009-08-10 02:56:21 | Re: Issues for named/mixed function notation patch |