Re: Docbook toolchain interfering with patch review?

From: Brendan Jurd <direvus(at)gmail(dot)com>
To: Josh Berkus <josh(at)agliodbs(dot)com>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Docbook toolchain interfering with patch review?
Date: 2009-07-17 00:07:31
Message-ID: 37ed240d0907161707q1dcd348cjc99b8ee8c9616009@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

2009/7/17 Josh Berkus <josh(at)agliodbs(dot)com>:
> This seems like a serious issue for development.  Reviewers, how many of you
> are able to build docs with each patch?

Being able to build docs did require some fidgeting with the docbook
packages (on Gentoo). The only trick was working out exactly which
packages I needed to install. Since getting past that, I've not had
any problems building the docs. Although it is pretty slow.

As Merlin and Andrew have noted, being able to build the docs is a
nice-to-have for documentation review, not a genuine requirement. You
*can* review changes to SGML right there in the diff. Especially if
the changes are not extensive and/or don't alter the structure of the
document.

Cheers,
BJ

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message KaiGai Kohei 2009-07-17 00:13:36 Re: [PATCH] [v8.5] Security checks on largeobjects
Previous Message Brendan Jurd 2009-07-16 23:51:56 Re: WIP: generalized index constraints