| From: | "Brendan Jurd" <direvus(at)gmail(dot)com> |
|---|---|
| To: | "Magnus Hagander" <magnus(at)hagander(dot)net> |
| Cc: | "Tom Lane" <tgl(at)sss(dot)pgh(dot)pa(dot)us>, "D'Arcy J(dot)M(dot) Cain" <darcy(at)druid(dot)net>, "Bruce Momjian" <bruce(at)momjian(dot)us>, "Josh Berkus" <josh(at)agliodbs(dot)com>, "Gregory Stark" <stark(at)enterprisedb(dot)com>, "PG Hackers" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Parsing of pg_hba.conf and authentication inconsistencies |
| Date: | 2008-09-15 14:05:10 |
| Message-ID: | 37ed240d0809150705g3a150bddj3007b8ac478c302a@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Sep 15, 2008 at 11:46 PM, Magnus Hagander <magnus(at)hagander(dot)net> wrote:
> Tom Lane wrote:
>>
>> Hm, that doesn't seem like a great improvement --- in particular, it
>> violates the style guideline that detail messages should be complete
>> sentences.
>>
>> I think the error text is all right as-is, really.
>
> I think I need to hit myself over the head with those guidelines
> repeatedly, because I think the *changed* messages are in violation of
> this, and need to be changed again...
>
Right, I was just applying the same DETAIL structure as was used
elsewhere in the patch. Tom's got a point about the complete
sentences though.
I still feel that the primary message is too long once the arguments
have been substituted in. How about just tweaking the DETAIL portion
so that it is a complete sentence?
Or perhaps the DETAIL portion would be more appropriate as a CONTEXT?
Cheers,
BJ
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2008-09-15 14:08:33 | Re: Parsing of pg_hba.conf and authentication inconsistencies |
| Previous Message | Tom Lane | 2008-09-15 14:04:33 | Re: rmgr hooks and contrib/rmgr_hook |