From: | "Brendan Jurd" <direvus(at)gmail(dot)com> |
---|---|
To: | "Alex Hunsaker" <badalex(at)gmail(dot)com> |
Cc: | pgsql-hackers(at)postgresql(dot)org |
Subject: | Re: [PATCHES] to_date() validation |
Date: | 2008-09-08 18:07:05 |
Message-ID: | 37ed240d0809081107o63e91b14h34ae40c7bd1288d2@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers pgsql-patches |
On Mon, Sep 8, 2008 at 6:24 PM, Brendan Jurd <direvus(at)gmail(dot)com> wrote:
> On Sun, Sep 7, 2008 at 5:58 AM, Alex Hunsaker <badalex(at)gmail(dot)com> wrote:
>> Code review: one minor nit
>> *** a/src/backend/utils/adt/formatting.c
>> --- b/src/backend/utils/adt/formatting.c
>> ***************
>> *** 781,787 **** static const KeyWord DCH_keywords[] = {
>> {"y", 1, DCH_Y, TRUE, FROM_CHAR_DATE_GREGORIAN},
>>
>> /* last */
>> ! {NULL, 0, 0, 0}
>> };
>>
>> /* ----------
>> --- 781,787 ----
>> {"y", 1, DCH_Y, TRUE, FROM_CHAR_DATE_GREGORIAN},
>>
>> /* last */
>> ! {NULL, 0, 0, 0, 0}
>> };
>
> Ah, thank you for picking that up. I will correct this and send in a
> new patch version in the next 24 hours.
>
New version attached (and link added to wiki).
Cheers,
BJ
Attachment | Content-Type | Size |
---|---|---|
to-date-validation-2.diff.gz | application/x-gzip | 9.4 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2008-09-08 18:18:16 | Re: [HACKERS] Infrastructure changes for recovery |
Previous Message | Simon Riggs | 2008-09-08 18:01:50 | Re: [HACKERS] Infrastructure changes for recovery |
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2008-09-08 18:18:16 | Re: [HACKERS] Infrastructure changes for recovery |
Previous Message | Simon Riggs | 2008-09-08 18:01:50 | Re: [HACKERS] Infrastructure changes for recovery |