pg_typeof() (was: Mysterious Bus Error with get_fn_expr_argtype())

On Tue, Sep 2, 2008 at 3:31 PM, Brendan Jurd <direvus(at)gmail(dot)com> wrote:
> Barring any further comments/objections, I'll go ahead and prepare a
> patch to add this to core.
>

Any opinions on where pg_typeof() should be defined? This function is
a little unusual and doesn't seem to slot nicely into any one of the
existing categories.

A few candidates:

* regproc.c - it contains functions for working with regtype.
* ruleutils.c - it contains a lot of other system information
functions, like pg_get_expr(), pg_get_userbyid(), et al.
* format_type.c - functions for presenting type information to the user.
* misc.c

Personally I'd be inclined to go with misc.c (if it's not clear where
it belongs, that probably makes it miscellany), but it's a weak
preference only.

Cheers,
BJ