| From: | Stas Kelvich <s(dot)kelvich(at)postgrespro(dot)ru> |
|---|---|
| To: | PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | unused_oids script is broken with bsd sed |
| Date: | 2018-04-25 10:22:41 |
| Message-ID: | 37D774E4-FE1F-437E-B3D2-593F314B7505@postgrespro.ru |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi.
BSD sed in macOS doesn't understand word boundary operator "\b". So after
372728b0d49 unused_oids doesn’t match all oids in new *.dat files marking
all of them as unused.
It is possible to write more portable regexps, e.g. change "\b" to
something like "^.*{*.*", but it seems easier for feature use to just
rewrite unused_oids in perl to match duplicate_oids. Also add in-place
complain about duplicates instead of running uniq through oids array.
--
Stas Kelvich
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-Rewrite-unused_oids-in-perl.patch | application/octet-stream | 3.1 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Ildus Kurbangaliev | 2018-04-25 11:13:24 | Translatable strings with formatting of 64bit values |
| Previous Message | Ashutosh Bapat | 2018-04-25 09:51:48 | Re: Expression errors with "FOR UPDATE" and postgres_fdw with partition wise join enabled. |