Missing break in RelationFindReplTupleSeq

From: Konstantin Knizhnik <k(dot)knizhnik(at)postgrespro(dot)ru>
To: PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Missing break in RelationFindReplTupleSeq
Date: 2020-01-31 13:46:36
Message-ID: 379743f6-ae91-b866-f7a2-5624e6d2b0a4@postgrespro.ru
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Eventually we find out that logical replication in the current version
of Postgres works significantly slower on table with replica identity
full than old pglogical implementation.

The comment to RelationFindReplTupleSeq says:

    Note that this stops on the first matching tuple.

But actually this function continue traversal until end of the table
even if tuple was found.
I wonder if break; should be added to the end of for loop.

--
Konstantin Knizhnik
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Alvaro Herrera 2020-01-31 13:58:31 Re: Missing break in RelationFindReplTupleSeq
Previous Message Alvaro Herrera 2020-01-31 13:40:45 Re: standby apply lag on inactive servers