| From: | Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com> |
|---|---|
| To: | Nathan Bossart <nathandbossart(at)gmail(dot)com> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Benoit Lobréau <benoit(dot)lobreau(at)gmail(dot)com>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Robert Haas <robertmhaas(at)gmail(dot)com>, "Bossart, Nathan" <bossartn(at)amazon(dot)com>, David Steele <david(at)pgmasters(dot)net>, Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>, Michael Paquier <michael(at)paquier(dot)xyz>, Magnus Hagander <magnus(at)hagander(dot)net>, Stephen Frost <sfrost(at)snowman(dot)net> |
| Subject: | Re: archive modules |
| Date: | 2022-09-14 20:07:11 |
| Message-ID: | 37857474-5caa-ccb3-92a3-150ddfe851ab@enterprisedb.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 14.09.22 22:03, Nathan Bossart wrote:
> On Wed, Sep 14, 2022 at 09:33:46PM +0200, Peter Eisentraut wrote:
>> Another question on this feature: Currently, if archive_library is set,
>> archive_command is ignored. I think if both are set, it should be an error.
>> Compare for example what happens if you set multiple recovery_target_xxx
>> settings. I don't think silently turning off one setting by setting another
>> is a good behavior.
>
> I originally did it this way, but changed it based on this feedback [0]. I
> have no problem with the general idea, but the recovery_target_* logic does
> have the following note:
>
> * XXX this code is broken by design. Throwing an error from a GUC assign
> * hook breaks fundamental assumptions of guc.c. So long as all the variables
> * for which this can happen are PGC_POSTMASTER, the consequences are limited,
> * since we'd just abort postmaster startup anyway. Nonetheless it's likely
> * that we have odd behaviors such as unexpected GUC ordering dependencies.
Ah yes, that won't work. But maybe we can just check it at run time,
like in LoadArchiveLibrary().
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2022-09-14 20:47:23 | Re: archive modules |
| Previous Message | Peter Eisentraut | 2022-09-14 20:03:50 | Re: cataloguing NOT NULL constraints |