Re: BUG #19613: pg_restore: several SEGVs in ReadToc() in pg_backup_archiver.c

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Andrey Borodin <x4mmm(at)yandex-team(dot)ru>
Cc: Andrey Rachitskiy <pl0h0yp1(at)gmail(dot)com>, ilia(dot)kashintsev(at)gmail(dot)com, PostgreSQL mailing lists <pgsql-bugs(at)lists(dot)postgresql(dot)org>
Subject: Re: BUG #19613: pg_restore: several SEGVs in ReadToc() in pg_backup_archiver.c
Date: 2026-08-14 16:33:07
Message-ID: 3767380.1786725187@sss.pgh.pa.us
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-bugs

Andrey Borodin <x4mmm(at)yandex-team(dot)ru> writes:
> Could we add a regression test?

-1 ... I think the engineering, maintenance, and runtime cost of a
test like this would never pay for itself. The thing you would wish
that a regression test could catch is adding a new TOC field that is
effectively required while failing to use ReadRequiredStr for it.
Which a test like this wouldn't.

regards, tom lane

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message PG Bug reporting form 2026-08-14 17:41:02 BUG #19619: WHERE scale(n) = 1 pushed past GROUP BY / window PARTITION BY, wrong COUNT
Previous Message Tom Lane 2026-08-14 16:15:44 Re: COPY TO regression with psql -c