| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Thomas Munro <thomas(dot)munro(at)gmail(dot)com> |
| Cc: | Jeff Davis <pgsql(at)j-davis(dot)com>, Peter Eisentraut <peter(at)eisentraut(dot)org>, Daniel Verite <daniel(at)manitou-mail(dot)org>, Robert Haas <robertmhaas(at)gmail(dot)com>, Jeremy Schneider <schneider(at)ardentperf(dot)com>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: Built-in CTYPE provider |
| Date: | 2024-03-19 04:03:01 |
| Message-ID: | 3744671.1710820981@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Thomas Munro <thomas(dot)munro(at)gmail(dot)com> writes:
> On Tue, Mar 19, 2024 at 11:55 AM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>>>> This is causing all CI jobs to fail the "compiler warnings" check.
>>> I did run CI before checkin, and it passed:
> Maybe I misunderstood this exchange but ...
> Currently Windows warnings don't make any CI tasks fail ie turn red,
> which is why Jeff's run is all green in his personal github repo.
> ...
> But I did teach cfbot to do some extra digging through the logs,
Ah. What I should have said was "it's causing cfbot to complain
about every patch".
Seems like the divergence in the pass criterion is not such a
great idea.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Himanshu Upadhyaya | 2024-03-19 04:03:53 | Re: remaining sql/json patches |
| Previous Message | Thomas Munro | 2024-03-19 03:38:57 | Re: Built-in CTYPE provider |