| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Andres Freund <andres(at)anarazel(dot)de>, bossartn(at)amazon(dot)com, Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, sulamul(at)gmail(dot)com, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: inefficient loop in StandbyReleaseLockList() |
| Date: | 2021-11-05 02:47:23 |
| Message-ID: | 373296.1636080443@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Michael Paquier <michael(at)paquier(dot)xyz> writes:
> On Thu, Nov 04, 2021 at 08:21:56PM -0400, Tom Lane wrote:
>> Hm. I think it's not the only list function with O(N) behavior;
>> in fact there used to be more such functions than there are now.
>> But I could get behind a patch that annotates all of them.
> Documenting that makes sense. Shouldn't we be careful to do that in
> both pg_list.h and list.c, then?
We have seldom, if ever, put function API-definition comments into .h files.
I do not see a reason why this case deserves an exception. (It's tough
enough to get people to maintain definition comments that are right beside
the code they describe --- I think putting them in .h files would be a
disaster.)
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Kyotaro Horiguchi | 2021-11-05 03:17:31 | Re: Allow escape in application_name |
| Previous Message | Michael Paquier | 2021-11-05 02:47:20 | Re: Teach pg_receivewal to use lz4 compression |