Re: On disable_cost

Robert Haas <robertmhaas(at)gmail(dot)com> writes:
> I'll look into this, unless you want to do it.

I have a draft patch already. Need to add a test case.

> Incidentally, another thing I just noticed is that
> IsCurrentOfClause()'s test for (node->cvarno == rel->relid) is
> possibly dead code. At least, there are no examples in our test suite
> where it fails to hold. Which seems like it makes sense, because if it
> didn't, then how did the clause end up in baserestrictinfo? Maybe this
> is worth keeping as defensive coding, or maybe it should be changed to
> an Assert or something.

I wouldn't remove it, but maybe an Assert is good enough. The tests
on Vars' varno should be equally pointless no?

regards, tom lane