| From: | Jeff Davis <pgsql(at)j-davis(dot)com> |
|---|---|
| To: | Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com> |
| Cc: | Taylor Vesely <tvesely(at)pivotal(dot)io>, Adam Lee <ali(at)pivotal(dot)io>, Melanie Plageman <mplageman(at)pivotal(dot)io>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: Memory-Bounded Hash Aggregation |
| Date: | 2020-02-06 02:20:22 |
| Message-ID: | 37091115219dd522fd9ed67333ee8ed1b7e09443.camel@j-davis.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, 2020-01-24 at 17:01 -0800, Jeff Davis wrote:
> New patch attached.
Three minor independent refactoring patches:
1. Add new entry points for the tuple hash table:
TupleHashTableHash()
LookupTupleHashEntryHash()
which are useful for saving and reusing hash values to avoid
recomputing.
2. Refactor hash_agg_entry_size() so that the callers don't need to do
as much work.
3. Save calculated aggcosts->transitionSpace in the Agg node for later
use, rather than discarding it.
These are helpful for the upcoming Hash Aggregation work.
Regards,
Jeff Davis
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-HashAgg-TupleHashTableHash-and-LookupTupleHashEntryH.patch | text/x-patch | 5.7 KB |
| 0002-HashAgg-make-hash_agg_entry_size-account-for-all-spa.patch | text/x-patch | 4.0 KB |
| 0003-HashAgg-save-calculated-transitionSpace-in-Agg-node.patch | text/x-patch | 5.6 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Langote | 2020-02-06 02:35:41 | Re: pg_stat_progress_basebackup - progress reporting for pg_basebackup, in the server side |
| Previous Message | Justin Pryzby | 2020-02-06 02:14:32 | typos in comments and user docs |