| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Andres Freund <andres(at)anarazel(dot)de> |
| Cc: | pgsql-hackers(at)postgresql(dot)org, Magnus Hagander <magnus(at)hagander(dot)net> |
| Subject: | Re: pg_basebackup WAL streamer shutdown is bogus - leading to slow tests |
| Date: | 2022-01-16 16:34:42 |
| Message-ID: | 3703646.1642350882@sss.pgh.pa.us |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Andres Freund <andres(at)anarazel(dot)de> writes:
> I don't immediately see a solution for this, other than to add
> StreamCtl->stop_event (mirroring ->stop_socket) and then convert
> CopyStreamPoll() to use WaitForMultipleObjects(). Microsoft's select()
> doesn't support pipes and there's no socketpair().
> Any more straightforward ideas?
> From a cursory look at history, it used to be that pg_basebackup had this
> behaviour on all platforms, but it got fixed for other platforms in
> 7834d20b57a by Tom (assuming the problem wasn't present there).
Hmm --- I see that I thought Windows was unaffected, but I didn't
consider this angle.
Can we send the child process a signal to kick it off its wait?
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Magnus Hagander | 2022-01-16 16:36:13 | Re: pg_basebackup WAL streamer shutdown is bogus - leading to slow tests |
| Previous Message | Magnus Hagander | 2022-01-16 11:35:56 | Re: pg_basebackup WAL streamer shutdown is bogus - leading to slow tests |