| From: | Sergei Kornilov <sk(at)zsrv(dot)org> |
|---|---|
| To: | Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com> |
| Cc: | Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, "andres(at)anarazel(dot)de" <andres(at)anarazel(dot)de>, "michael(at)paquier(dot)xyz" <michael(at)paquier(dot)xyz>, "david(at)pgmasters(dot)net" <david(at)pgmasters(dot)net>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: allow online change primary_conninfo |
| Date: | 2020-01-21 15:03:18 |
| Message-ID: | 370331579618998@vla3-6a5326aeb4ee.qloud-c.yandex.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hello
"Waiting on Author" is the right status. I found logical conflict with recently added wal_receiver_create_temp_slot GUC and my tests are currently broken. Will fix it and post new version.
PS: also, I surprised why it's ok for wal_receiver_create_temp_slot to be PGC_SIGHUP and ignore change of this setting until walreceiver will reconnect by unrelated reason. I means walreceiver does nothing special on SIGHUP. In common case change of wal_receiver_create_temp_slot setting will have effect only during restart of walreceiver process. And therefore we will switch to archive recovery. But such design was strongly rejected for my patch year ago.
regards, Sergei
| From | Date | Subject | |
|---|---|---|---|
| Next Message | James Coleman | 2020-01-21 15:03:31 | Re: [PATCH] Incremental sort (was: PoC: Partial sort) |
| Previous Message | Tomas Vondra | 2020-01-21 14:58:32 | Re: [PATCH] Incremental sort (was: PoC: Partial sort) |