Re: [HACKERS] Modulo syntax

From: Thomas Lockhart <lockhart(at)alumni(dot)caltech(dot)edu>
To: Bruce Momjian <maillist(at)candle(dot)pha(dot)pa(dot)us>
Cc: phd2(at)earthling(dot)net, pgsql-hackers(at)postgreSQL(dot)org
Subject: Re: [HACKERS] Modulo syntax
Date: 1999-03-26 15:57:06
Message-ID: 36FBAE52.56C10B72@alumni.caltech.edu
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> > I ran the query
> > update producers SET cor_id = producer_id % 9 + 1;
> > and found that result is eqiuvalent to
> > update producers SET cor_id = producer_id % 9;
> > I added parens:
> > update producers SET cor_id = (producer_id % 9) + 1;
> > and got what I needed.
> Looks like a bug. We have associativity for +, -, * and /, but not %.
> From gram.y:
> %left '+' '-'
> %left '*' '/'
> I will add '%' to that.

This will not fix the associativity problem, unless you *also* go
through and add the explicit syntax *throughout* gram.y, as is
currently done for '+', '-', etc.

I'm pretty sure that we don't want to do this, since there are way too
many other operators which would need the same treatment.

The correct solution will be to identify the operator as a particular
class in scan.l, include that class in the associativity declarations,
and then handle that class in the body of gram.y. Sort of like we do
for generic operators already, but with some discrimination between
them. To be done right, we should look up the precedence in a db
table, to allow new operators to participate in the scheme. In any
case, gram.y will become more complex...

Unless we are going to solve this, I would suggest backing out the
change in gram.y.

- Tom

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Jan Wieck 1999-03-26 16:17:16 Re: [HACKERS] PostgreSQL LOGO (was: Developers Globe (FINAL))
Previous Message Tom Lane 1999-03-26 15:35:33 pg_parg system table is suffering from software rot