| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
| Cc: | Daniel Gustafsson <daniel(at)yesql(dot)se>, Greg Nancarrow <gregn4422(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Windows build warnings |
| Date: | 2021-11-22 15:06:37 |
| Message-ID: | 3698888.1637593597@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> writes:
> .. but see
> https://postgr.es/m/CAH2-WznwWU+9on9nZCnZtk7uA238MCTgPxYr1Ty7U_Msn5ZGwQ@mail.gmail.com
> where this was already discussed. I think if we're going to workaround
> PG_USED_FOR_ASSERTS_ONLY not actually working, we may as well get rid of
> it entirely. My preference would be to fix it so that it works on more
> platforms (at least Windows in addition to GCC).
Yeah, I do not think there is a reason to change the code if it's using
PG_USED_FOR_ASSERTS_ONLY properly. We should either make that macro
work on $compiler, or ignore such warnings from $compiler.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2021-11-22 15:08:17 | Re: Building postgresql armv7 on emulated x86_64 |
| Previous Message | Julien Rouhaud | 2021-11-22 14:50:04 | Re: An obsolete comment of pg_stat_statements |