Re: [HACKERS] Time to change pg_regress diffs to unified by default?

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>
Cc: Christoph Berg <myon(at)debian(dot)org>, Noah Misch <noah(at)leadboat(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: [HACKERS] Time to change pg_regress diffs to unified by default?
Date: 2019-01-02 20:44:49
Message-ID: 3689.1546461889@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> writes:
> While we're considering the pg_regress output, what do you think about
> replacing the ======... separator with a standard diff separator like
> "diff %s %s %s\n". This would make the file behave more like a proper
> diff file, for use with other tools. And it shows the diff options
> used, for clarity. See attached patch.

I'm confused by this patch. Doesn't moving the diff call like that
break the logic completely?

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message James Robinson 2019-01-02 20:57:33 Arrays of domain returned to client as non-builtin oid describing the array, not the base array type's oid
Previous Message Peter Eisentraut 2019-01-02 20:38:40 Re: psql display of foreign keys