| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | ITAGAKI Takahiro <itagaki(dot)takahiro(at)oss(dot)ntt(dot)co(dot)jp> |
| Cc: | pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: Error correction for n_dead_tuples |
| Date: | 2007-05-27 03:59:03 |
| Message-ID: | 3682.1180238343@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
I think this patch needs to be revisited in the light of the work I just
did to make pgstats correctly track the effects of aborted transactions.
It seems fairly likely to me that most of the problem you were seeing
was actually due to that stupidity, and not to race conditions between
VACUUM and concurrent transactions. So maybe we no longer need to do
anything.
It might be worth fixing things so that a VACUUM sets n_dead_tuples to
the number of deleted-but-not-removable tuples it saw, rather than
always setting to zero as is presently done.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Matthew O'Connor | 2007-05-27 04:44:15 | Re: Autovacuum versus rolled-back transactions |
| Previous Message | Jaime Casanova | 2007-05-26 23:34:29 | Re: Reviewing temp_tablespaces GUC patch |