Re: pg_subscription.subslotname is wrongly marked NOT NULL

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: pg_subscription.subslotname is wrongly marked NOT NULL
Date: 2020-07-19 23:48:18
Message-ID: 367660.1595202498@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

I wrote:
> pg_subscription_rel.srsublsn also needs to be marked nullable.

Not only is it wrongly marked attnotnull, but two of the three places
that read it are doing so unsafely (ie, as though it *were*
non-nullable). So I think we'd better fix it as attached.

regards, tom lane

Attachment Content-Type Size
fix-srsublsn-usage-for-nullness.patch text/x-diff 3.2 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tomas Vondra 2020-07-20 00:48:27 Re: Default setting for enable_hashagg_disk
Previous Message Tom Lane 2020-07-19 22:04:43 Re: pg_subscription.subslotname is wrongly marked NOT NULL