From: | Jesper Pedersen <jesper(dot)pedersen(at)redhat(dot)com> |
---|---|
To: | David Rowley <david(dot)rowley(at)2ndquadrant(dot)com> |
Cc: | Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp>, Rajkumar Raghuwanshi <rajkumar(dot)raghuwanshi(at)enterprisedb(dot)com>, Beena Emerson <memissemerson(at)gmail(dot)com>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Robert Haas <robertmhaas(at)gmail(dot)com>, amul sul <sulamul(at)gmail(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>, Dilip Kumar <dilipbalaut(at)gmail(dot)com> |
Subject: | Re: [HACKERS] Runtime Partition Pruning |
Date: | 2018-04-03 17:44:37 |
Message-ID: | 366cf4f7-ca8d-baa1-f65b-67949b56afb1@redhat.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Hi David,
On 03/31/2018 09:52 AM, David Rowley wrote:
> I've attached a new version of the patch. I'm now at v18 after having
> some versions of the patch that I didn't release which were based on
> various versions of Amit's faster partition pruning patch.
>
Thank you for the updated patch set !
I have tested this together with Amit's v46 patch.
The attached case doesn't trigger a generic plan, so basically all time
is spent in GetCachedPlan.
The standard table case (std.sql) gives:
generic_cost = 8.4525
avg_custom_cost = 13.4525
total_custom_cost = 67.2625
whereas the 64 hash partition case (hash.sql) gives:
generic_cost = 540.32
avg_custom_cost = 175.9425
total_custom_cost = 879.7125
I tested with pgbench -M prepared -f select.sql.
Also, I'm seeing a regression for check-world in
src/test/regress/results/inherit.out
***************
*** 642,648 ****
---------------------+---+---+-----
mlparted_tab_part1 | 1 | a |
mlparted_tab_part2a | 2 | a |
! mlparted_tab_part2b | 2 | b | xxx
mlparted_tab_part3 | 3 | a | xxx
(4 rows)
--- 642,648 ----
---------------------+---+---+-----
mlparted_tab_part1 | 1 | a |
mlparted_tab_part2a | 2 | a |
! mlparted_tab_part2b | 2 | b |
mlparted_tab_part3 | 3 | a | xxx
(4 rows)
I'll spend some more time tomorrow.
Thanks for working on this !
Best regards,
Jesper
Attachment | Content-Type | Size |
---|---|---|
hash.sql | application/sql | 5.1 KB |
select.sql | application/sql | 85 bytes |
std.sql | application/sql | 124 bytes |
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2018-04-03 17:47:18 | Re: Optimize Arm64 crc32c implementation in Postgresql |
Previous Message | Tom Lane | 2018-04-03 17:39:36 | Re: BRIN FSM vacuuming questions |