| From: | Ken Kato <katouknl(at)oss(dot)nttdata(dot)com> |
|---|---|
| To: | Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com> |
| Cc: | pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: [PATCH] Add min() and max() aggregate functions for xid8 |
| Date: | 2022-02-08 09:43:18 |
| Message-ID: | 366448a09d8c2265f5f85d4363e0512c@oss.nttdata.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2022-02-08 15:34, Fujii Masao wrote:
> Thanks for updating the patch! It basically looks good to me. I
> applied the following small changes to the patch. Updated version of
> the patch attached. Could you review this version?
Thank you for the patch!
It looks good to me!
I'm not sure how strict coding conventions are, but the following line
is over 80 characters.
+insert into xid8_t1 values ('0'), ('010'), ('42'),
('0xffffffffffffffff'), ('-1');
Therefore, I made a patch which removed ('010') just to fit in 80
characters.
Best wishes,
--
Ken Kato
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION
| Attachment | Content-Type | Size |
|---|---|---|
| min_max_aggregates_for_xid8_v5.patch | text/x-diff | 6.3 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Kapila | 2022-02-08 09:51:19 | Re: [BUG]Update Toast data failure in logical replication |
| Previous Message | kuroda.hayato@fujitsu.com | 2022-02-08 09:18:28 | RE: Logical replication timeout problem |