| From: | Andrew Dunstan <andrew(dot)dunstan(at)2ndquadrant(dot)com> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
| Cc: | Kyotaro HORIGUCHI <horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp>, sawada(dot)mshk(at)gmail(dot)com, tgl(at)sss(dot)pgh(dot)pa(dot)us, sk(at)zsrv(dot)org, nasbyj(at)amazon(dot)com, andres(at)anarazel(dot)de, robertmhaas(at)gmail(dot)com, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: pgsql: Improve autovacuum logging for aggressive and anti-wraparound ru |
| Date: | 2019-03-30 12:16:21 |
| Message-ID: | 3627b6eb-3bfc-ccb3-45e7-a0c96d23abb3@2ndQuadrant.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
On 3/29/19 9:08 PM, Michael Paquier wrote:
> On Fri, Mar 29, 2019 at 11:22:55AM -0300, Alvaro Herrera wrote:
>> Yeah, that looks good to me too. I wonder if we really need it as LOG
>> though; we don't say anything for actions unless they take more than the
>> min duration, so why say something for a no-op that takes almost no time?
>> Maybe make it DEBUG1.
> I think that this does not justify a WARNING, as that's harmless for
> the user even if we use WARNING for other skips (see
> vacuum_is_relation_owner). However DEBUG1 is also too low in my
> opinion as this log can be used as an indicator that autovacuum is too
> much aggressive because there are too many workers for example. I
> have seen that matter in some CPU-bound environments. I won't fight
> hard if the consensus is to use DEBUG1 though. So, more opinions?
> Andrew perhaps?
>
>
It's really just a matter of housekeeping as I see it, so probably
DEBUG1 is right.
cheers
andrew
--
Andrew Dunstan https://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2019-03-30 13:12:33 | Re: pgsql: Improve autovacuum logging for aggressive and anti-wraparound ru |
| Previous Message | Thomas Munro | 2019-03-30 10:32:22 | Re: pgsql: Compute XID horizon for page level index vacuum on primary. |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2019-03-30 13:12:33 | Re: pgsql: Improve autovacuum logging for aggressive and anti-wraparound ru |
| Previous Message | Magnus Hagander | 2019-03-30 11:56:21 | Re: Online verification of checksums |