Re: pgsql: libpq: Grease the protocol by default

[ moving discussion to -hackers ]

Jacob Champion <jacob(dot)champion(at)enterprisedb(dot)com> writes:
> crake is angry:

>> pg_dumpall: error: connection to server on socket "/home/andrew/bf/root/tmp/buildfarm-onigY7/.s.PGSQL.5670" failed: FATAL: unsupported frontend protocol 3.9999: server supports 1.0 to 3.0
>> This indicates a bug in either the server being contacted
>> or a proxy handling the connection. Please consider
>> ...

> So while this is kind of a nice result, in that it's correctly
> diagnosing the problem, I need to add max_protocol_version=3.0 to the
> connection strings for these upgrades during beta.

Either that or we decide that it's time to throw 9.2 support
overboard (looks like 9.3 and up are fine).

If it's not hard to add the connection option to this test, let's do
that --- but if it is a problem, I wouldn't shed too many tears over
moving the oldest-old-version goalpost. I think we might not be able
to fix the test without changing buildfarm client script and/or
configuration.

regards, tom lane