| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com> |
| Cc: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>, Mikael Kjellström <mikael(dot)kjellstrom(at)gmail(dot)com> |
| Subject: | Re: Re: [COMMITTERS] pgsql: Modify the isolation tester so that multiple sessions can wait. |
| Date: | 2016-04-27 22:15:07 |
| Message-ID: | 3621.1461795307@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com> writes:
>> Also happens on OpenBSD 5.8. Isn't this a classic case where memmove
>> is called for? Replacing the memcpy at line 617 with memmove makes
>> the tests run successfully, but at first glance the other two
>> instances of memcpy in run_permutation should also be changed to
>> memmove, no?
Yeah, that's clearly busted. Surprising that it has not failed on
any other platforms.
> Suggested patch attached.
Will push in a moment.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2016-04-27 22:19:32 | pgsql: Use memmove() not memcpy() to slide some pointers down. |
| Previous Message | Tom Lane | 2016-04-27 21:55:39 | pgsql: Clean up parsing of synchronous_standby_names GUC variable. |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Mikael Kjellström | 2016-04-27 22:44:03 | Re: Re: [COMMITTERS] pgsql: Modify the isolation tester so that multiple sessions can wait. |
| Previous Message | Tom Lane | 2016-04-27 22:10:54 | Re: pgindent |