Re: Query generates infinite loop

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Corey Huinker <corey(dot)huinker(at)gmail(dot)com>
Cc: Jeff Janes <jeff(dot)janes(at)gmail(dot)com>, Richard Wesley <richard(at)duckdblabs(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Query generates infinite loop
Date: 2022-05-09 04:02:57
Message-ID: 3603504.1652068977@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs pgsql-hackers

Corey Huinker <corey(dot)huinker(at)gmail(dot)com> writes:
> On Wed, May 4, 2022 at 3:01 PM Jeff Janes <jeff(dot)janes(at)gmail(dot)com> wrote:
>> On Wed, Apr 20, 2022 at 5:43 PM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>>> Oh --- looks like numeric generate_series() already throws error for
>>> this, so we should just make the timestamp variants do the same.

> This came up once before
> https://www.postgresql.org/message-id/CAB7nPqQUuUh_W3s55eSiMnt901Ud3meF7f_96yPkKcqfd1ZaMg%40mail.gmail.com

Oh! I'd totally forgotten that thread, but given that discussion,
and particularly the counterexample at

https://www.postgresql.org/message-id/16807.1456091547%40sss.pgh.pa.us

it now feels to me like maybe this change was a mistake. Perhaps
instead of the committed change, we ought to go the other way and
rip out the infinity checks in numeric generate_series().

In view of tomorrow's minor-release wrap, there is not time for
the sort of more leisured discussion that I now think this topic
needs. I propose to revert eafdf9de0 et al before the wrap,
and think about this at more length before doing anything.

regards, tom lane

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message Amit Kapila 2022-05-09 04:08:03 Re: Security Definer functions no longer works in PG14+
Previous Message Corey Huinker 2022-05-09 03:44:33 Re: Query generates infinite loop

Browse pgsql-hackers by date

  From Date Subject
Next Message Corey Huinker 2022-05-09 06:19:30 Re: Query generates infinite loop
Previous Message Amit Kapila 2022-05-09 03:45:58 Re: bogus: logical replication rows/cols combinations