| From: | Jesper Pedersen <jesper(dot)pedersen(at)redhat(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Sokolov Yura <funny(dot)falcon(at)postgrespro(dot)ru> |
| Cc: | pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: Fix performance of generic atomics |
| Date: | 2017-09-05 18:39:05 |
| Message-ID: | 36029be0-e886-34fe-1c81-8d18be4a5fbe@redhat.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 09/05/2017 02:24 PM, Tom Lane wrote:
> Jesper Pedersen <jesper(dot)pedersen(at)redhat(dot)com> writes:
>> I have tested this patch on a 2-socket machine, but don't see any
>> performance change in the various runs. However, there is no regression
>> either in all cases.
>
> Hm, so if we can't demonstrate a performance win, it's hard to justify
> risking touching this code. What test case(s) did you use?
>
I ran pgbench (-M prepared) with synchronous_commit 'on' and 'off' using
both logged and unlogged tables. Also ran an internal benchmark which
didn't show anything either.
Setting the entry back to "Needs Review" for additional feedback from
others.
Best regards,
Jesper
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Greg Stark | 2017-09-05 18:43:33 | Re: JIT compiling expressions/deform + inlining prototype v2.0 |
| Previous Message | Tom Lane | 2017-09-05 18:24:38 | Re: Fix performance of generic atomics |