| From: | Andrei Lepikhov <lepihov(at)gmail(dot)com> |
|---|---|
| To: | Yurii Rashkovskii <yrashk(at)omnigres(dot)com> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Add Postgres module info |
| Date: | 2024-12-27 01:34:00 |
| Message-ID: | 35f29bde-ccc7-41b3-8c13-6ff30c196a93@gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 12/24/24 10:42, Yurii Rashkovskii wrote:
> On Mon, Dec 16, 2024 at 12:02 PM Andrei Lepikhov <lepihov(at)gmail(dot)com
> I've reviewed the patch, and it is great that you support more flexible
> versioning now. I am just wondering a bit about the case where `minfo-
> >name` can be `NULL` but `minfo->version` isn't, or where both are
> `NULL` – should we skip any of these?
Depends. I wrote code that way so as not to restrict a maintainer by
initialising all the fields; remember, it may grow in the future.
But I am open to changing that logic. Do you have any specific rule on
which fields may be empty and that must be initialised? Do you think all
fields maintainer must fill with non-zero-length constants?
Also, I've added this patch to commitfest:
https://commitfest.postgresql.org/51/5465/
--
regards, Andrei Lepikhov
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bruce Momjian | 2024-12-27 01:47:19 | Re: Support for unsigned integer types |
| Previous Message | Kohei Harikae (Fujitsu) | 2024-12-27 01:31:33 | RE: Windows meson build |