| From: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
|---|---|
| To: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
| Cc: | "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: pg_upgrade version checking questions |
| Date: | 2021-03-03 08:57:38 |
| Message-ID: | 35ec2a77-2d38-d65e-fe9f-737a0c0c2955@2ndquadrant.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 02.03.21 22:51, Daniel Gustafsson wrote:
>> The commit message says something about "to ensure the health of the target cluster", which doesn't make sense to me. Maybe find a better wording.
>
> Reworded in the attached updated version.
>
>> The name find_exec() seems not very accurate. It doesn't find anything. Maybe "check"?
>
> I'm not wild about check_exec(), but every other name I could think of was
> drastically worse so I went with check_exec.
>
>> I'm not sure why the new find_exec() adds EXE. AFAIK, this is only required for stat(), and validate_exec() already does it.
>
> Good point, fixed.
I committed this. I added a pg_strip_crlf() so that there are no
newlines in the error message. I also slightly reworded the error
message to make the found and expected value distinguishable.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Langote | 2021-03-03 08:58:32 | Re: A reloption for partitioned tables - parallel_workers |
| Previous Message | Amit Langote | 2021-03-03 08:56:40 | Re: Increase value of OUTER_VAR |